Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration document and add manage realm rights #57

Merged
merged 2 commits into from
Dec 18, 2023
Merged

configuration document and add manage realm rights #57

merged 2 commits into from
Dec 18, 2023
+55 −6

Conversation

cgeorgilakis
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.07s
❌ COPYPASTE jscpd yes 115 7.06s
❌ JAVA checkstyle 77 348 9.29s
❌ JAVA pmd 77 1 10.67s
⚠️ MARKDOWN markdownlint 1 7 0.52s
✅ MARKDOWN markdown-link-check 1 0 0.5s
⚠️ MARKDOWN markdown-table-formatter 1 1 1.86s
❌ REPOSITORY checkov yes 3 19.99s
✅ REPOSITORY gitleaks yes no 5.19s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 4.31s
❌ REPOSITORY trivy yes 1 8.44s
❌ SPELL cspell 83 311 22.26s
✅ SPELL misspell 82 0 0.17s
✅ XML xmllint 2 0 0.02s
⚠️ YAML prettier 2 1 0.79s
✅ YAML v8r 2 0 3.43s
❌ YAML yamllint 2 1 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

NicolasLiampotis
NicolasLiampotis requested changes Dec 8, 2023
View reviewed changes
README.md Outdated
--header 'Authorization: Bearer {admin_access_token}' \
--header 'Content-Type: application/json' \
--data '{
"userAttribute" : "eduPersonEntitlement",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should change to entitlements

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
--header 'Content-Type: application/json' \
--data '{
"userAttribute" : "eduPersonEntitlement",
"urnNamespace" : "urn%3Agrnett%3Aeosc-portal.eu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "urn%3Amace%3Aexample.org"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
--data '{
"userAttribute" : "eduPersonEntitlement",
"urnNamespace" : "urn%3Agrnett%3Aeosc-portal.eu",
"authority" : "aai.eosc-portal.eu"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to "authority" : "rciam.example.org" // Optional. It will be omitted from the group entitlements if not specified

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Show resolved Hide resolved
NicolasLiampotis
NicolasLiampotis approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@NicolasLiampotis NicolasLiampotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for config params of the validation rules will be improved in a next iteration. Other than that LGTM

@NicolasLiampotis NicolasLiampotis merged commit 6af4b65 into version_22 Dec 18, 2023
1 of 2 checks passed
@cgeorgilakis cgeorgilakis deleted the configuration-documentation branch November 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasLiampotis NicolasLiampotis NicolasLiampotis approved these changes

@linathedog linathedog Awaiting requested review from linathedog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgeorgilakis @NicolasLiampotis